Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Improve gas fee and price logging in TransactionManager #954

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Jul 12, 2024

Changes

  • Improve attempt count comparison
  • Improve logging of BigNumber gas price and gas fee values

HT to @chriswessels for these changes which were pulled almost wholesale from #392

Copy link
Contributor

@dwerner dwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fordN fordN merged commit f7bfcdd into main Jul 12, 2024
10 checks passed
@fordN fordN deleted the ford/improve-gas-price-logs branch July 12, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants