Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Remove failed subgraph check #984

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

dwerner
Copy link
Contributor

@dwerner dwerner commented Aug 8, 2024

Recreating #983 for @datanexus-vincent so CI can run on this.

@dwerner dwerner requested a review from fordN August 8, 2024 17:06
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fordN
Copy link
Contributor

fordN commented Aug 14, 2024

Approved! Can we update commit message to match our format before merging?

@datanexus-vincent
Copy link

Approved! Can we update commit message to match our format before merging?

Pushed a new commit message on my branch. I'll make sure to use the correct formatting for future PR commits. Thanks for approving!

@dwerner dwerner force-pushed the datanexus-vincent-support-failed-subgraphs branch from 77da351 to 7dbd177 Compare August 14, 2024 20:13
@dwerner
Copy link
Contributor Author

dwerner commented Aug 14, 2024

Approved! Can we update commit message to match our format before merging?

Pushed a new commit message on my branch. I'll make sure to use the correct formatting for future PR commits. Thanks for approving!

Sorry, already took care of it here.

@dwerner dwerner merged commit ca9f2db into main Aug 14, 2024
6 of 9 checks passed
@dwerner dwerner deleted the datanexus-vincent-support-failed-subgraphs branch August 14, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants