Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use markup key to indicate expected diagnostics location #3861

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

gao-artur
Copy link
Contributor

No description provided.

@gao-artur gao-artur added the analyzers Changes to analyzers label Dec 29, 2023
@gao-artur gao-artur self-assigned this Dec 29, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b912f8) 84.67% compared to head (4d02834) 84.66%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3861      +/-   ##
==========================================
- Coverage   84.67%   84.66%   -0.02%     
==========================================
  Files         419      419              
  Lines       19333    19333              
  Branches     3033     3033              
==========================================
- Hits        16370    16368       -2     
- Misses       2251     2252       +1     
- Partials      712      713       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shane32 Shane32 added the test Pull request that adds new or changes existing tests label Dec 29, 2023
@Shane32
Copy link
Member

Shane32 commented Dec 29, 2023

FYI, the only time I use the test label is when the PR only applies to tests. Since typically any programming change should add/change tests, so I don't label those with the test label.

@Shane32
Copy link
Member

Shane32 commented Dec 29, 2023

This PR looks good!

@gao-artur gao-artur merged commit f8ede76 into master Dec 30, 2023
11 checks passed
@gao-artur gao-artur deleted the analyzers/use-markup-key-for-location branch December 30, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzers Changes to analyzers test Pull request that adds new or changes existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants