-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AST printer #20
AST printer #20
Conversation
5c35178
to
2595bfb
Compare
2595bfb
to
6bf6bfc
Compare
I think this should code should write values to a TextWriter - no concatenation. Ideally it should support both synchronous and asynchronous writing in case the target is a socket or filestream. Conversion to a string can be handled by a StringWriter (which is backed by a StringBuilder). |
@Shane32 Do you want to work on this? |
I think we should remove the AST model tree from GraphQL.NET, and rewrite the library to simply use the classes provided within this project. Optionally, we could move the AST classes to a separate project that provides the models only (e.g. GraphQL.Language.Abstractions), and both projects could rely on that abstraction library of models. It would save a lot of cpu time/memory that currently just is wasted copying information. Then I think we may be able to remove the AST printer from there, and add it here, which seems to be a more logical place for it (being both I/O for query to string translation). If you would agree that it is our goal, then I could be talked into working on it. It wouldn't be hard. But I don't have any need for two AST printers, let alone one. |
Actually the SchemaPrinter might use a Schema, not AST. So these printers may be different. I'm not sure as I've never used a SchemaPrinter or AST printer. Perhaps, however, they could share code. Not sure without digging deeper. |
Let's postpone this for the next major version (not "current next"). |
No description provided.