Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a mutation example #124

Closed
wants to merge 2 commits into from

Conversation

jaredonline
Copy link
Contributor

Adds the simple mutation for #60

Left to do:

  • add an http based example

Adds the simple mutation for graphql-go#60

Left to do:
 [ ] add an http based example
@coveralls
Copy link

Coverage Status

Coverage increased (+3.0%) to 90.543% when pulling f1155e6 on jaredonline:mutation-example into 909ca9f on graphql-go:master.

Adding an http example for graphql-go#60

Left to do:
 - [ ] clean up the schema so its only in one place
@coveralls
Copy link

Coverage Status

Coverage increased (+3.0%) to 90.543% when pulling 48847e3 on jaredonline:mutation-example into 909ca9f on graphql-go:master.

@chris-ramon
Copy link
Member

Hi @jaredonline!, thanks a lot for taking the time to work on this! 👍

I'd like to suggest adding this todo mutation example to the existing examples/todo/main.go one.

@jaredonline
Copy link
Contributor Author

Oh! Nice! I wasn't aware that the mutation example for Todos was already there @chris-ramon. Should I put remove my example entirely and just add the new mutation to the existing todo stuff? Should #60 be closed then?

@chris-ramon
Copy link
Member

chris-ramon commented Apr 20, 2016

Should I put remove my example entirely and just add the new mutation to the existing todo stuff?

That would be awesome @jaredonline, so the todo example would keep becoming solid & continue showing important features to lib users.

And yes! this PR would be closing #60.

@chris-ramon
Copy link
Member

Closing this one in favor of #189

Thanks for the initial work @jaredonline 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants