handler: consolidates FormatErrorFn

[chris-ramon]

Overview

• Related: handler: adds formatErrorFn #58 (comment)
• Upstream related PR: errors: consolidates original error for re-usability graphql#427
• handler: Updates Handler.FormatErrorFn signature:
  • From: formatErrorFn func(err gqlerrors.FormattedError) gqlerrors.FormattedError
  • To: formatErrorFn func(err error) gqlerrors.FormattedError

Test plan

• Unit tests.

[AutomateAaron]

This seemed to have broken my ability to go get github.com/graphql-go/handler, I'm now getting the following errors:

# github.com/graphql-go/handler
projects/gopath/src/github.com/graphql-go/handler/handler.go:147:47: formattedError.OriginalError undefined (type gqlerrors.FormattedError has no field or method OriginalError)

[chris-ramon]

Hi @AaronNBrock, I believe updating github.com/graphql-go/graphql should fix the issue your describing:

go get -u github.com/graphql-go/graphql

---

I've reproduce the issue you might facing, breaking in steps to fix it:

(handler)-> pwd
/home/chris/.gvm/pkgsets/go1.9.7/gql/src/github.com/graphql-go/handler

(handler)-> git log -n 1
commit bece7a661c2640529c5131854692a9d38150defc
Merge: 12f536e d08c809
Author: Chris Ramón <rchristian.ramon@gmail.com>
Date:   Sun Dec 9 19:33:33 2018 -0500

    Merge pull request #59 from graphql-go/updated-format-error-fn
    
    handler: consolidates FormatErrorFn

(handler)-> go test ./...
# github.com/graphql-go/handler
./handler.go:147:47: formattedError.OriginalError undefined (type gqlerrors.FormattedError has no field or method OriginalError)
FAIL    github.com/graphql-go/handler [build failed]

(handler)-> (cd ../ && cd graphql && git log -n 1)
commit 8000299290374795a939114c26e9e2a39de08213
Merge: 993e01c 31bba03
Author: Chris Ramón <rchristian.ramon@gmail.com>
Date:   Sun Dec 2 18:00:55 2018 -0500

    Merge pull request #425 from graphql-go/enable-go-module
    
    Use Go Modules.

(handler)-> go get -u github.com/graphql-go/graphql
(handler)-> 

(handler)-> go test ./...
ok      github.com/graphql-go/handler   0.005s

[AutomateAaron]

@chris-ramon That was exactly my problem, updating github.com/graphql-go/graphql solved it!