Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add execute-timeout argument for gql-cli #349

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Add execute-timeout argument for gql-cli #349

merged 3 commits into from
Jul 28, 2022

Conversation

leszekhanusz
Copy link
Collaborator

See issue #347

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #349 (0fabc21) into master (5713ac7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #349   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         2232      2243   +11     
=========================================
+ Hits          2232      2243   +11
Impacted Files Coverage Δ
gql/cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5713ac7...0fabc21. Read the comment docs.

@leszekhanusz leszekhanusz mentioned this pull request Jul 28, 2022
Closed
gonzalezzfelipe
gonzalezzfelipe reviewed Jul 28, 2022
View reviewed changes
gql/cli.py Outdated Show resolved Hide resolved
gonzalezzfelipe
gonzalezzfelipe approved these changes Jul 28, 2022
View reviewed changes
Copy link

@gonzalezzfelipe gonzalezzfelipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leszekhanusz leszekhanusz merged commit a7f7649 into graphql-python:master Jul 28, 2022
@leszekhanusz leszekhanusz deleted the feature_execute_timeout_argument_with_gql_cli branch July 28, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonzalezzfelipe gonzalezzfelipe gonzalezzfelipe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leszekhanusz @codecov-commenter @gonzalezzfelipe