-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore update graphql core to 3.3.0 and dropping support for Python 3.6 #363
Chore update graphql core to 3.3.0 and dropping support for Python 3.6 #363
Conversation
leszekhanusz
commented
Sep 24, 2022
•
edited
Loading
edited
- Following graphql-core update to 3.3.0a1
- Adding spaces in tests following graphql-core update
- Dropping support for Python 3.6
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 2215 2215
=========================================
Hits 2215 2215 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
̶@̶C̶i̶t̶o̶ ̶a̶n̶y̶ ̶i̶d̶e̶a̶ ̶w̶h̶y̶ ̶p̶y̶p̶y̶3̶ ̶c̶a̶n̶n̶o̶t̶ ̶f̶i̶n̶d̶ ̶g̶r̶a̶p̶h̶q̶l̶-̶c̶o̶r̶e̶ ̶v̶e̶r̶s̶i̶o̶n̶ ̶3̶.̶3̶.̶0̶a̶1̶ ̶?̶ Nevermind, it's because pypy3 still uses Python 3.6 |
@leszekhanusz is this PR ready to ship? I'd love to get a new release of gql with a setup.py version bump of graphql-core that allows 3.3 to work (https://github.com/graphql-python/gql/blob/master/setup.py#L6). |
graphql-core 3.3 is still in alpha. I was thinking about waiting until a stable graphql-core release before merging this PR and making a new gql release. But we could make a gql pre-release. @Cito What do you think, should I make a gql pre-release |
A pre-release of gql would be awesome if it makes sense 👍 |
That would be great, in order to find any incompatibilities and to test the new features in core 3.3. |
Pre-Release v3.5.0a0 is now available. |
Thanks so much @leszekhanusz! Really appreciate it |