-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync batching to requests sync transport #431
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 27 28 +1
Lines 2388 2492 +104
==========================================
+ Hits 2388 2492 +104
☔ View full report in Codecov by Sentry. |
No clue why some tests are failing because of some missing Edited: Because of some missing test marks |
In the CI, we are testing that some tests are supposed to work only with a single transport dependency installed. If you run It is possible to mark the tests to specify which test can be run in which condition. But I just see that you found out about it just now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look good already!
Also nice to see that the countries.trevorblades.com site we use for our tests supports batch requests.
I've noted a few requested changes.
If you could also please check again all the docstrings so that the parameters correspond to the new ones and the text is modified to say that it's a batch operation.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed some fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nitpicking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice work! 😄 |
Thanks for your help! |
Feature
Enable batching.
It adds
execute_batch
method forTransport
andClient
in order to allow users to send multiple requests at once.Server must allow this type of requests.
Issue: #430
Resources: