Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphene 3 dataloader #1273

Closed
wakemaster39 opened this issue Oct 7, 2020 · 2 comments
Closed

Graphene 3 dataloader #1273

wakemaster39 opened this issue Oct 7, 2020 · 2 comments
Labels

Comments

@wakemaster39
Copy link

wakemaster39 commented Oct 7, 2020

Current documentation for graphene on both the released site and the master branch have the promise based dataloader as the recommended method of using dataloaders.

Since promise is no longer included in the graphene and there is no thenable resolution in the chain anymore, how can dataloaders be executed in a synchronous application like flask? I found https://github.com/syrusakbary/aiodataloader which provided an async/await dataloader interface but flask doesn't support it out of the box.

I have hacked in a loop.run_until_complete() when executing a graphql request to try and enable dataloaders again but this seems suspect and that I am missing something.

@KingDarBoja
Copy link

Related to graphql-python/graphql-server#66 as well 🚀

@jkimbo
Copy link
Member

jkimbo commented Oct 27, 2020

@wakemaster39 docs have been updated here: #1190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants