-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dataloader docs [Waiting for Graphene v3 to be live] #1190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Although let's make sure we publish it once Graphene 3 is live in PyPI so we don't confuse users
Has everyone lost interest in this project? 8 pending reviewers 7 months after the MR was created.. This isn't confidence inspiring for others who are thinking of contributing :) Is there perhaps conversation about this elsewhere? |
@skewty there are some discussions about contributing on slack https://graphenetools.slack.com/ |
Why isn't this merged? The documentation is wrong and if you are using the latest Graphene version the data loaders didn't work. Do you need any change in the proposed change? I can create a new PR with the changes if needed |
Codecov Report
@@ Coverage Diff @@
## master #1190 +/- ##
=======================================
Coverage 95.59% 95.59%
=======================================
Files 49 49
Lines 1565 1565
=======================================
Hits 1496 1496
Misses 69 69 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Resolves #1189
Also adds a basic to test to make sure that aiodataloader works.