Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dataloader docs [Waiting for Graphene v3 to be live] #1190

Merged
merged 5 commits into from
Aug 13, 2022

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Apr 26, 2020

Resolves #1189

Also adds a basic to test to make sure that aiodataloader works.

Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Although let's make sure we publish it once Graphene 3 is live in PyPI so we don't confuse users

@stale stale bot added the wontfix label Aug 1, 2020
@graphql-python graphql-python deleted a comment from stale bot Aug 5, 2020
@jkimbo jkimbo mentioned this pull request Oct 27, 2020
@ekampf ekampf changed the title Update Dataloader docs Update Dataloader docs [Waiting for Graphene v3 to be live] Nov 17, 2020
@skewty
Copy link

skewty commented Nov 27, 2020

Has everyone lost interest in this project? 8 pending reviewers 7 months after the MR was created.. This isn't confidence inspiring for others who are thinking of contributing :) Is there perhaps conversation about this elsewhere?

@fabienheureux
Copy link

Has everyone lost interest in this project? 8 pending reviewers 7 months after the MR was created.. This isn't confidence inspiring for others who are thinking of contributing :) Is there perhaps conversation about this elsewhere?

@skewty there are some discussions about contributing on slack https://graphenetools.slack.com/

@nykolaslima
Copy link

Why isn't this merged?

The documentation is wrong and if you are using the latest Graphene version the data loaders didn't work.

Do you need any change in the proposed change? I can create a new PR with the changes if needed

erikwrede and others added 2 commits August 13, 2022 15:08
Co-authored-by: Justin Miller <justinrmiller@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1190 (8e1c3d3) into master (80e3498) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1190   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          49       49           
  Lines        1565     1565           
=======================================
  Hits         1496     1496           
  Misses         69       69           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@erikwrede erikwrede merged commit 57f3aa3 into master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dataloader docs to use aiodataloader
8 participants