-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually run the tests in python 3.12 and 3.13 and remove snapshottest
dependency
#1572
Conversation
From what I can tell there are at least two open pull requests in |
so that the tests pass in 3.12 and 3.13 again
because the snapshottest package doesn't work on Python 3.12 and above
snapshottest
dependency
I also dropped the |
I did notice that tests on Python 3.12 are not working as expected, but hadn't chance to dig into it. Thank you 🙏 I agree that Graphene needs to drop snapshottest as it's failing to work on Python 3.12 and above. I'll try to take time and review your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@erikwrede ping? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, currently really busy in my day-to-day.
Thanks for picking this up and pinging me!
Seems like we have some test failures in 3.13. Will investigate later. |
looks like the |
Thank you! |
I noticed that 614449e (PR #1550) introduced an invalid tox environment:
py12
instead ofpy312
. This mistake was later repeated in 6834385 (PR #1561):py13
instead ofpy313
.On my machine,
tox list
outputs:And
tox run
doesn't run any tests in thepy312
andpy313
environments. This is also true in the Github workflows.For example, in this "successful" run in the
py312
environment from 2024-07-01 tox only runspip install .[test]
and nothing else.This looks very different from this run in the
py311
environment, which also runspytest
:This PR actually runs the tests in the
py312
andpy313
and drops thesnapshottest
dependency (which was only used in the example tests) so that the tests also work in Python 3.12 and above. This is necessary becausesnapshottest
(which appears dead) is using Python'simp
module, which has been deprected since 3.4 and was removed in 3.12.