Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider hash method of AST nodes #45

Closed
Cito opened this issue Jul 19, 2019 · 1 comment
Closed

Reconsider hash method of AST nodes #45

Cito opened this issue Jul 19, 2019 · 1 comment
Assignees
@Cito

Comments

@Cito
Copy link
Member

Cito commented Jul 19, 2019 •
edited
Loading

The nodes in "language.ast" should probably not be hashable, because they are mutable and currently equal values have different hashes (see also graphql-python/graphql-core/issues/252).
@Cito Cito self-assigned this Jul 19, 2019
@Cito Cito added the investigate Needs investigaton or experimentation label Jul 19, 2019
Cito added a commit that referenced this issue Aug 1, 2019
@Cito
Use FrozenLists in AST nodes, fix hash (#45)
b5532a4 
Partially replicates graphql/graphql-js@9b2e626
@Cito Cito removed the investigate Needs investigaton or experimentation label Aug 1, 2019
@Cito
Copy link
Member Author

Cito commented Aug 1, 2019

The nodes are immutable now, and hashes properly implemented.

@Cito Cito closed this as completed Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cito Cito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cito