perf: call cacheKeyFn only when it is needed (if caching) #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abendi
changed the title
dimaMachina
approved these changes
Jul 11, 2024
|
@dimaMachina Thanks for the approval. I added a test case as well and had to fix a flow error. I don't like the usage of |
ardatan
approved these changes
Jul 11, 2024
|
can you please create changeset? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
cacheKeyFnwas called unnecessarily with caching disabled ascacheKeywas never used in such case. This PR makes surecacheKeyFnis called only when caching is enabled andcacheKeyis actually needed. SometimescacheKeyFncan use more expensive code, such asJSON.stringify, in which case it is preferred not to waste CPU cycles.