fix: check window is defined before using it
#962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
=======================================
Coverage 33.78% 33.78%
=======================================
Files 79 79
Lines 3481 3481
Branches 753 752 -1
=======================================
Hits 1176 1176
Misses 1814 1814
Partials 491 491
Continue to review full report at Codecov.
|
benjie
requested changes
Sep 24, 2019
Co-Authored-By: Benjie Gillam <benjie@jemjie.com>
|
@benjie Yes now working. I exported the package with the fix and used it here https://www.assim.me/resume |
benjie
changed the title
window is defined before using it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I was trying to use GraphiQL with Gatsby but I got
window is not definedissue.