Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #53, #55, #48, #59 (partially) and added mock call operators #64

Merged
merged 55 commits into from
Nov 21, 2020
Merged

Fixes #53, #55, #48, #59 (partially) and added mock call operators #64

merged 55 commits into from
Nov 21, 2020

Conversation

sgissinger
Copy link
Contributor

No description provided.

@sgissinger sgissinger changed the title Fixes #53, #55 and once negated a sentence stays negated Fixes #53, #55 and added MagickMock call expectations Nov 17, 2020
@sgissinger sgissinger mentioned this pull request Nov 17, 2020
Closed
@sgissinger
Copy link
Contributor Author

I don't know why, MagicMock operators do not works with | should assertion style.

@h2non h2non self-assigned this Nov 17, 2020
@h2non
Copy link
Member

h2non commented Nov 17, 2020

Thanks for the PR and work done here!

Would you mind fixing the CI builds with code format issues?
https://travis-ci.org/github/grappa-py/grappa/builds/744179148

@sgissinger
Copy link
Contributor Author

sgissinger commented Nov 18, 2020 •
edited
Loading

You're welcome.
Java-style assertions are so painful, I will never go back to these things 😃.

I added a GitHub Action workflow for the fun.
One advantage over Travis CI is that it runs almost instantly and on all types of OSes.
For PyPy2 I have the same errors on been_called operators tests

@sgissinger sgissinger changed the title Fixes #53, #55 and added MagickMock call expectations Fixes #53, #55, #48, added mock call operators Nov 18, 2020
@sgissinger sgissinger changed the title Fixes #53, #55, #48, added mock call operators Fixes #53, #55, #48, #59 (partially) and added mock call operators Nov 18, 2020
@sgissinger
Copy link
Contributor Author

@h2non I promise I stop to push 'til you choose to merge now :-)

@h2non h2non merged commit fbaf340 into grappa-py:master Nov 21, 2020
@h2non
Copy link
Member

h2non commented Nov 21, 2020

Thanks for the nice work here.

New version v1.0.0 is now available on PyPI:
https://pypi.org/project/grappa/

Upgrade it by running: pip install --upgrade grappa

@sgissinger sgissinger mentioned this pull request Nov 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@h2non h2non

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgissinger @h2non