Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing CGDB to work OOTB with no errors #26

Closed
wants to merge 1 commit into from
Closed

Fixing CGDB to work OOTB with no errors #26

wants to merge 1 commit into from

Conversation

jaredweiss
Copy link
Contributor

Simplified several steps

  • Fixed loading without a material (needed for most current CGDB)
  • Added a warning if CGDB is built and run without CGDB_MODEL_ROOT envvar
  • Fixed failure on grasps not exactly matching schema (also needed for most current CGDB)

@jvarley @mateiciocarlie Please review

Fixing CGDB to work OOTB with no errors
1222268 
Simplified several steps
 - Fixed loading without a material (needed for most current CGDB)
 - Added a warning if CGDB is built and run without CGDB_MODEL_ROOT envvar
 - Fixed failure on grasps not exactly matching schema (also needed for most current CGDB)
@jvarley
Copy link
Member

jvarley commented Mar 30, 2016

@mateiciocarlie
This should probably be pulled in as well. We threw a version of the database on a server in the corner of the lab. And I don't see any reason to not allow external access to it.

mateiciocarlie
mateiciocarlie reviewed Apr 5, 2016
View reviewed changes
src/DBase/DBPlanner/database.h
return (column_num < data_.size())
? QVariantConvert(data_[column_num][row_num], result)
: false;
return QVariantConvert(data_[column_num][row_num], result);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this help anything? If column_nm >= data_.size() I think this will segfault.

@jaredweiss
Copy link
Contributor Author

@mateiciocarlie
One quick question before I incorporate your feedback from the last round of review.
In graspit_db_model it seems like regardless of whether or not a geometry file is properly loaded, it always will say it failed. I was wondering if I should just remove these lines?

@mateiciocarlie
Copy link
Member

Huh - that is a good point, I never noticed that... Instead of removing, can you please replace them with something along the lines of "Attempting to load geometry from file ..." ?

@Shashank35 Shashank35 mentioned this pull request Jun 28, 2016
Closed
@jvarley jvarley mentioned this pull request Aug 15, 2016
Closed
@jvarley jvarley mentioned this pull request Mar 13, 2017
Closed
@jvarley jvarley mentioned this pull request Jun 15, 2017
Closed
@mateiciocarlie
Copy link
Member

Unfortunately, we will not be able to support CGDB in the future, so will just close this....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaredweiss @jvarley @mateiciocarlie