-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add support for GTK 3.20+ #3
Comments
For future reference, this fork has 3.22 support: Thanks @grassmunk for creating this great theme and @AdrianoML for the rewrite to GTK 3.22. |
If grassmunk is still around, I can make a pull request |
Hi All, Yes I'm here, though sporadically, I would love a pull request. I've also incorporated the changes outlined here: https://www.reddit.com/r/unixporn/comments/68i7ut/xfce_classic_redmond_grey_theme_updated/ |
Are you using gtk 3.18? The changes made for 3.20 unfortunately make it incompatible with previous versions. I've tried it on ubuntu 16.04 which uses gtk 3.18, and it has the same issues, on all gtk3 apps. We could still try and distribute both versions. |
The beleveling was being generated because all those elements are embedded on a notebook. I have now found out that gtk sets a .frame style for notebooks that are supposed to be "floating around" rather than integrated in a window. I've commited a patch where I don't add a frame nor some padding to notebboks without a .frame style. This seems to solve the issue. (although sometimes the effect loked cool) The horizontal lines showing in view/treeview elements are by design. I don't know why it's showing vertical ones. I might try showing them in a more selective way later. |
Thanks for doing this! |
Please add support for GTK 3.20+
The text was updated successfully, but these errors were encountered: