Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for GTK 3.20+ #3

Closed
DocMAX opened this issue Oct 15, 2016 · 8 comments
Closed

Please add support for GTK 3.20+ #3

DocMAX opened this issue Oct 15, 2016 · 8 comments

Comments

@DocMAX
Copy link

DocMAX commented Oct 15, 2016

Please add support for GTK 3.20+

@tjohnman
Copy link

For future reference, this fork has 3.22 support:
https://github.com/AdrianoML/Chicago95

Thanks @grassmunk for creating this great theme and @AdrianoML for the rewrite to GTK 3.22.

@amlib
Copy link
Contributor

amlib commented May 3, 2017

If grassmunk is still around, I can make a pull request

@grassmunk
Copy link
Owner

Hi All,

Yes I'm here, though sporadically, I would love a pull request.

I've also incorporated the changes outlined here: https://www.reddit.com/r/unixporn/comments/68i7ut/xfce_classic_redmond_grey_theme_updated/

@grassmunk
Copy link
Owner

grassmunk commented May 3, 2017

Ok I went and did some testing with Mousepad (one of the first gtk3 apps in ubuntu) with your fork and noticed that it didn't display properly. Here's with Chicago95 current (without your changes):
screen shot 2017-05-03 at 3 11 05 pm

Notice the menus and the arrow keys don't seem to work. And neither does the file selector.

Compare that with the current Chicago95 theme:
screen shot 2017-05-03 at 3 25 54 pm

@amlib
Copy link
Contributor

amlib commented May 4, 2017

Are you using gtk 3.18? The changes made for 3.20 unfortunately make it incompatible with previous versions. I've tried it on ubuntu 16.04 which uses gtk 3.18, and it has the same issues, on all gtk3 apps.

We could still try and distribute both versions.

@grassmunk
Copy link
Owner

Good catch. Yeah I was using an older Ubuntu. Just install 17.04 and tested it out. Looks great but had some questions/comments.

  1. When looking at lists (like in Whisker, but alsp in the choose file dialogue for mousepad) there's a thin line between items. Any way to get rid of that line or is that a gtk3 requirements? Here's an example screenshot:
    screenfetch-2017-05-03_21-49-57

  2. There's a 'bevel' around windows interiors. For example look at mousepad and terminal in this screenshot. There's this 2-3 pixel border around the internal window in both when there shouldn't be any.
    screenfetch-2017-05-03_21-48-46

Compare with my example screenshots posted previously which doesn't have the window bevel or compare to screenshot of the original notepad in windows 95.
image

@amlib
Copy link
Contributor

amlib commented May 4, 2017

The beleveling was being generated because all those elements are embedded on a notebook. I have now found out that gtk sets a .frame style for notebooks that are supposed to be "floating around" rather than integrated in a window. I've commited a patch where I don't add a frame nor some padding to notebboks without a .frame style. This seems to solve the issue. (although sometimes the effect loked cool)

The horizontal lines showing in view/treeview elements are by design. I don't know why it's showing vertical ones. I might try showing them in a more selective way later.

@grassmunk
Copy link
Owner

Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants