Skip to content
This repository has been archived by the owner on Jun 7, 2024. It is now read-only.

Fix: React modules cause an app crash #5

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Fix: React modules cause an app crash #5

merged 2 commits into from
Aug 2, 2023

Conversation

wellyshen
Copy link
Contributor

@wellyshen wellyshen commented Aug 2, 2023 •
edited
Loading

Related to #4

Proposed Changes

  • Correct the externals field of the Webpack config for React modules

Testing Instructions

  • React modules should work well as below (fixing by replace the React with react):
Untitled.mp4

@wellyshen wellyshen self-assigned this Aug 2, 2023
@wellyshen wellyshen changed the title Fix/the externals of react modules Fix: The wrong externals setup for React modules Aug 2, 2023
@wellyshen wellyshen changed the title Fix: The wrong externals setup for React modules Fix: React modules cause an app crash Aug 2, 2023
@wellyshen wellyshen disabled auto-merge August 2, 2023 15:15
@wellyshen wellyshen enabled auto-merge (squash) August 2, 2023 15:17
@wellyshen wellyshen merged commit 877d5f8 into trunk Aug 2, 2023
2 checks passed
@wellyshen wellyshen deleted the fix/the-externals-of-react-modules branch August 2, 2023 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johngodley johngodley johngodley approved these changes

Assignees

@wellyshen wellyshen

Labels
[Status] Needs code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wellyshen @johngodley