Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate the preset auditor logins #25840

Closed
rosstimothy opened this issue May 8, 2023 · 0 comments · Fixed by #43551
Closed

Investigate the preset auditor logins #25840

rosstimothy opened this issue May 8, 2023 · 0 comments · Fixed by #43551

Comments

@rosstimothy
Copy link
Contributor

Determine if the login is still necessary and if not remove it. There are no protections in place against a user manually removing the login from their auditor role, so anything dependent on it being present is not guaranteed to work.

teleport/lib/services/presets.go

Line 188 in 49b2379

role.SetLogins(types.Allow, []string{"no-login-" + uuid.New().String()})

@rosstimothy rosstimothy added bug and removed bug labels May 8, 2023
rosstimothy added a commit that referenced this issue Jun 26, 2024
@rosstimothy
Remove random no-login- set on auditor role
4585678 
There is nothing that consumes or requires the randomly generated
login applied to the preset auditor role, and nothing that prevents
a user from removing it. This login was determined to be vestigial
and seve no purpose anymore.

Closes #25840
@rosstimothy rosstimothy mentioned this issue Jun 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 26, 2024
@rosstimothy
Remove random no-login- set on auditor role (#43551)
a6a0dd6 
There is nothing that consumes or requires the randomly generated
login applied to the preset auditor role, and nothing that prevents
a user from removing it. This login was determined to be vestigial
and seve no purpose anymore.

Closes #25840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove random no-login- set on auditor role gravitational/teleport
1 participant
@rosstimothy