-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for specifying roles when making Resource Access Requests in the UI #18036
Conversation
5e02cd4
to
ecdf4db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a unit test, probably TestPruneRequestRoles
can have a couple lines added to make sure the CalculateAccessCapabilities
output matches what's expected for each of the existing test cases
Added a connect counterpart here #18508 |
d1d477d
to
5caf8bf
Compare
5caf8bf
to
3b820fb
Compare
…e Access Requests in the UI) (#18538)
…e Access Requests in the UI) (#18868)
Purpose
This PR extends
getAccessCapabilities
to return the list of necessary roles to access a given set of resources when provided with the resource ID's.backend counterpart to gravitational/webapps#1321
e
counterpart: https://github.com/gravitational/teleport.e/pull/589