Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for specifying roles when making Resource Access Requests in the UI #18036

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

rudream
Copy link
Contributor

@rudream rudream commented Nov 2, 2022

Purpose

This PR extends getAccessCapabilities to return the list of necessary roles to access a given set of resources when provided with the resource ID's.

backend counterpart to gravitational/webapps#1321
e counterpart: https://github.com/gravitational/teleport.e/pull/589

@rudream rudream marked this pull request as ready for review November 11, 2022 17:31
@rudream rudream requested review from zmb3 and nklaassen and removed request for ravicious and strideynet November 11, 2022 17:46
@rudream rudream force-pushed the yassine/select-resource-roles branch from 5e02cd4 to ecdf4db Compare November 11, 2022 17:57
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise looks good.

api/proto/teleport/legacy/types/types.proto Outdated Show resolved Hide resolved
api/proto/teleport/legacy/types/types.proto Show resolved Hide resolved
Copy link
Contributor

@nklaassen nklaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a unit test, probably TestPruneRequestRoles can have a couple lines added to make sure the CalculateAccessCapabilities output matches what's expected for each of the existing test cases

lib/services/access_request.go Outdated Show resolved Hide resolved
lib/services/access_request.go Outdated Show resolved Hide resolved
api/proto/teleport/legacy/types/types.proto Outdated Show resolved Hide resolved
@avatus
Copy link
Contributor

avatus commented Nov 16, 2022

Added a connect counterpart here #18508

@r0mant r0mant mentioned this pull request Nov 16, 2022
@rudream rudream force-pushed the yassine/select-resource-roles branch from d1d477d to 5caf8bf Compare November 16, 2022 22:29
@rudream rudream force-pushed the yassine/select-resource-roles branch from 5caf8bf to 3b820fb Compare November 16, 2022 22:32
rudream added a commit that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants