Proto changes for partial cache #24229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiko
force-pushed
the
andrey/partial-cache-proto
branch
from
10a32aa
to
80d68c3
Compare
rosstimothy
reviewed
Apr 6, 2023
|
All checks are passing now. Although it seems that there is some existing flaky race detection going on in the tests. |
andreiko
force-pushed
the
andrey/partial-cache-proto
branch
from
0996c32
to
24f1096
Compare
rosstimothy
approved these changes
Apr 6, 2023
zmb3
approved these changes
Apr 7, 2023
public-teleport-github-review-bot
bot
removed request for
fspmarshall and
atburke
andreiko
force-pushed
the
andrey/partial-cache-proto
branch
from
24f1096
to
989c353
Compare
andreiko
added a commit
that referenced
this pull request
Apr 10, 2023
andreiko
added a commit
that referenced
this pull request
Apr 25, 2023
espadolini
added a commit
that referenced
this pull request
May 23, 2023
espadolini
added a commit
that referenced
this pull request
May 23, 2023
espadolini
added a commit
that referenced
this pull request
May 24, 2023
espadolini
added a commit
that referenced
this pull request
May 25, 2023
espadolini
added a commit
that referenced
this pull request
May 25, 2023
espadolini
added a commit
that referenced
this pull request
May 26, 2023
espadolini
added a commit
that referenced
this pull request
May 26, 2023
espadolini
added a commit
that referenced
this pull request
May 26, 2023
* Use WIRE_JSON in buf breaking * Fix minor breaks in events.proto * Partial backport of #24229
espadolini
added a commit
that referenced
this pull request
May 26, 2023
* Use WIRE_JSON in buf breaking * Remove "backwards" reservations from proto * Fix minor breaks * Partial backport of #24229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #21586
Related RFD: 0114 - Partial cache healthiness
Changes summary
WatchStatusV1which is going to be attached to OpInit events.WatchfieldAllowPartialSuccesswhich is going to enable partial success mode forWatchEvents().WatchKindfrom auth service proto to types because it's used byWatchStatusV1. As a result, two existingWatchKindstructs in go code were consolidated in one;Note: moving the message from one proto to another and importing it from the former doesn't cause compatibility issues in either direction.