Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include url and saml connector name in entity descriptor url errors #33278

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

stevenGravy
Copy link
Contributor

Errors can occur if a SAML entity descriptor url is no longer available. Without knowing the connector name it's difficult to know which SAML connector is having the problem just from the entity descriptor url.

tctl get connectors

If a entity descriptor url fails you get the error:

ERROR: rpc error: code = Unknown desc = Get "https://gravitational-preview.oktapreview.com/app/exk7073it1Ywz0t8L1d7/sso/saml/metadata": dial tcp 4.4.4.4:443: i/o timeout

Updated to this so you get the url and the saml connector name okta.

ERROR: rpc error: code = Unknown desc = error getting entitydescriptor from "https://gravitational-preview.oktapreview.com/app/exk7073it1Ywz0t8L1d7/sso/saml/metadata" for SAML connector:okta
        Get "https://gravitational-preview.oktapreview.com/app/exk7073it1Ywz0t8L1d7/sso/saml/metadata": dial tcp 4.4.4.4:443: i/o timeout

lib/services/saml.go Outdated Show resolved Hide resolved
lib/services/saml.go Outdated Show resolved Hide resolved
stevenGravy and others added 2 commits October 18, 2023 16:25
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@stevenGravy stevenGravy added this pull request to the merge queue Oct 18, 2023
Merged via the queue into master with commit 436d429 Oct 18, 2023
28 checks passed
@stevenGravy stevenGravy deleted the stevenGravy/samlurlentityerror branch October 18, 2023 21:14
@public-teleport-github-review-bot

@stevenGravy See the table below for backport results.

Branch Result
branch/v12 Create PR
branch/v13 Create PR
branch/v14 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants