Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak caused by otelhttp #38844

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Fix memory leak caused by otelhttp #38844

merged 3 commits into from
Mar 4, 2024

Conversation

strideynet
Copy link
Contributor

@strideynet
Copy link
Contributor Author

@rosstimothy thoughts on backporting this? We've not backported the otel upgrade, but I worry if there's a security patch, we may end up doing so.

@github-actions github-actions bot requested review from Joerger and tigrato March 1, 2024 11:52
@strideynet strideynet added the no-changelog Indicates that a PR does not require a changelog entry label Mar 1, 2024
@gravitational gravitational deleted a comment from github-actions bot Mar 1, 2024
rosstimothy
rosstimothy approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@rosstimothy rosstimothy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with backporting this.

@strideynet
Copy link
Contributor Author

Going to let this run in the tbot-proving-ground over the weekend and check this resolves the leak.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from Joerger March 1, 2024 14:02
@strideynet
Copy link
Contributor Author

image
Before and After seems to indicate this patch fixes the memory leak

@strideynet strideynet added this pull request to the merge queue Mar 4, 2024
Merged via the queue into master with commit 59cf8b5 Mar 4, 2024
38 checks passed
@strideynet strideynet deleted the strideynet/fix-otelhttp-memory-leak-lol branch March 4, 2024 09:31
@public-teleport-github-review-bot
Copy link

@strideynet See the table below for backport results.

Branch Result
branch/v13 Failed
branch/v14 Failed
branch/v15 Failed

strideynet added a commit that referenced this pull request Mar 4, 2024
@strideynet
Fix memory leak caused by otelhttp (#38844)
33a72fa 
* Fix memory leak caused by otelhttp

* go mod tidy

* go mod tidy
@strideynet strideynet mentioned this pull request Mar 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrato tigrato tigrato approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

Assignees
No one assigned
Labels
backport/branch/v13 backport/branch/v14 backport/branch/v15 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strideynet @tigrato @rosstimothy