Enable access monitoring rules for mattermost plugin #42498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
r0mant
approved these changes
Jun 6, 2024
tigrato
approved these changes
Jun 6, 2024
public-teleport-github-review-bot
bot
removed the request for review
from marcoandredinis
17 tasks
|
@EdwardDowling Can you add some test coverage here before merging? Also, is there a corresponding teleport.e PR? |
marcoandredinis
approved these changes
Jun 27, 2024
|
@EdwardDowling See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables Mattermost plugin to use Access Monitoring Rules
A follow up PR will be made in /e to update the webui to include this.
changelog: Enable Access Monitoring Rules routing with Mattermost plugin