Remove rate limiting on webapi/ping and webapi/connectionupgrade #42799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The limits on these endpoints can cause issues with legitimate use cases trying to establish large numbers of connections from a single host(i.e. Ansible Tower). Extending the limits would likely result in a bar that constantly needs to be raised as clusters with this workflow become larger. Instead the limits were removed entirely.
zmb3
approved these changes
Jun 11, 2024
nklaassen
approved these changes
Jun 11, 2024
public-teleport-github-review-bot
bot
removed request for
probakowski,
bl-nero and
codingllama
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
@rosstimothy See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limits on these endpoints can cause issues with legitimate use cases trying to establish large numbers of connections from a single host(i.e. Ansible Tower). Extending the limits would likely result in a bar that constantly needs to be raised as clusters with this workflow become larger. Instead the limits were removed entirely.
changelog: Remote rate limits on endpoints used extensively to connect to the cluster