JIRA plugin: ensure Summary is less than 255 chars #42825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
approved these changes
Jun 12, 2024
|
I removed the backport to v14 as we don't cut plugin releases from this version. v15 is the first version to receive backports. |
zmb3
reviewed
Jun 12, 2024
integrations/access/jira/client.go
Outdated
| return summary | ||
| } | ||
|
|
||
| return summary[:strings.LastIndexAny(summary[:254], ",")] |
There was a problem hiding this comment.
Should we just say "my user request 12 roles" instead of truncating the role list?
marcoandredinis
force-pushed
the
marco/jira_summary_255_chars
branch
from
335b7bb
to
b218ba0
Compare
zmb3
approved these changes
Jun 12, 2024
public-teleport-github-review-bot
bot
removed the request for review
from Joerger
marcoandredinis
force-pushed
the
marco/jira_summary_255_chars
branch
from
b218ba0
to
8c41c7f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@marcoandredinis See the table below for backport results.
|
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix Jira Issue creation when Summary exceeds the max allowed size