configurable key algorithms for proxy to database agent certs #43329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
database-access
nklaassen
force-pushed
the
nklaassen/algs1
branch
from
4754767
to
c20955d
Compare
nklaassen
force-pushed
the
nklaassen/proxy-db-key-algo
branch
from
054294a
to
768904d
Compare
nklaassen
added
the
no-changelog
nklaassen
force-pushed
the
nklaassen/algs1
branch
from
c20955d
to
c58e850
Compare
nklaassen
force-pushed
the
nklaassen/proxy-db-key-algo
branch
from
050490c
to
96466ed
Compare
greedy52
approved these changes
Jun 25, 2024
smallinsky
approved these changes
Jun 25, 2024
nklaassen
force-pushed
the
nklaassen/algs1
branch
from
4cc0d87
to
dbe5bd7
Compare
nklaassen
force-pushed
the
nklaassen/proxy-db-key-algo
branch
from
6b3e2a3
to
f44ee97
Compare
nklaassen
force-pushed
the
nklaassen/algs0
branch
from
205ff64
to
f6d09da
Compare
nklaassen
force-pushed
the
nklaassen/proxy-db-key-algo
branch
from
f44ee97
to
a07297f
Compare
nklaassen
force-pushed
the
nklaassen/proxy-db-key-algo
branch
from
964c72a
to
47280c8
Compare
nklaassen
force-pushed
the
nklaassen/proxy-db-key-algo
branch
from
47280c8
to
5af9eff
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the implementation of RFD 136 - Modern Signature Algorithms.
The proxy currently generates a new keypair on each incoming connection from a user database client, and has the auth server sign a TLS certificate that it then uses to dial the db agent through the reverse tunnel that the database agent has already established to the proxy. These certs carry routing information for the database. These certs are signed by the Database CA and only need to be trusted by database agents. This PR updates these generated keys to use a signature algorithm matching the signature algorithm suite currently configured in the cluster.
This has the potential to boost proxy performance since it's so much faster to generate ECDSA keys than RSA keys. If I disable pre-generated RSA key generation,
go test ./lib/srv/dbspeeds up from4m4sto3m14swith this change (there are still plenty of other RSA keys being generated).