Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Machine ID Onboarding UI #45305

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Conversation

strideynet
Copy link
Contributor

@strideynet strideynet commented Aug 9, 2024

I was recording a demo reel that included this feature and I noticed two problems:

  • The Bot was not actually assigned the role that was created.
  • The example output YAML was malformed.

I appreciate I may not have fixed this in the most "correct" way so I'm open to feedback 😓 It's been a long time since I've dived into the frontend.

changelog: Fixed the "Create A Bot" flow for GitHub Actions and SSH. It now correctly grants the bot the role created during the flow, and the example YAML is now correctly formatted.

@strideynet strideynet marked this pull request as ready for review August 9, 2024 08:42
@github-actions github-actions bot requested review from avatus and rudream August 9, 2024 08:43
Copy link
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works!

what does the botName have to do with roles? I don't see that in the docs so I'm a bit confused (im probably missing it in the docs tbh).

can we update the changelog to state what it fixed? Something like

Create A Bot github workflow now correctly sets the botname

or

Create a Bot for Github Actions workflows now display proper yaml

but feel free to pick and choose any/all suggestions. I won't die on any of these hills.

@strideynet
Copy link
Contributor Author

what does the botName have to do with roles? I don't see that in the docs so I'm a bit confused (im probably missing it in the docs tbh).

Just further up in the implementation, we create a role named after the bot. We want the bot to have this role, so it needs to be included in the creation request. It'd probably a be a lot clearer if I'd reshuffled the code around so we could reference the created roles name here (even if this is ultimately just botName), but that got into the territory I'm much less familiar with 😭

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from rudream August 13, 2024 08:39
@strideynet strideynet added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit 120c079 Aug 13, 2024
42 of 43 checks passed
@strideynet strideynet deleted the strideynet/fix-tbot-onboarding branch August 13, 2024 08:59
@public-teleport-github-review-bot

@strideynet See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants