-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Machine ID Onboarding UI #45305
Fix Machine ID Onboarding UI #45305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works, it works!
what does the botName
have to do with roles? I don't see that in the docs so I'm a bit confused (im probably missing it in the docs tbh).
can we update the changelog to state what it fixed? Something like
Create A Bot github workflow now correctly sets the botname
or
Create a Bot for Github Actions workflows now display proper yaml
but feel free to pick and choose any/all suggestions. I won't die on any of these hills.
Just further up in the implementation, we create a role named after the bot. We want the bot to have this role, so it needs to be included in the creation request. It'd probably a be a lot clearer if I'd reshuffled the code around so we could reference the created roles name here (even if this is ultimately just |
@strideynet See the table below for backport results.
|
I was recording a demo reel that included this feature and I noticed two problems:
I appreciate I may not have fixed this in the most "correct" way so I'm open to feedback 😓 It's been a long time since I've dived into the frontend.
changelog: Fixed the "Create A Bot" flow for GitHub Actions and SSH. It now correctly grants the bot the role created during the flow, and the example YAML is now correctly formatted.