Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine node registration method based on server port #5347

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Determine node registration method based on server port #5347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 30 additions & 22 deletions lib/auth/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,37 +109,47 @@ func Register(params RegisterParams) (*Identity, error) {
return nil, trace.Wrap(err)
}

// Attempt to register through the auth server, if it fails, try and
// register through the proxy server.
ident, err := registerThroughAuth(token, params)
if err != nil {
// If no params client was set this is a proxy and fail right away.
if params.GetHostCredentials == nil {
log.Debugf("Missing client, failing with error from Auth Server: %v.", err)
return nil, trace.Wrap(err)
}
log.WithField("auth-servers", params.Servers).Debugf("Registering node to the cluster.")

log.Errorf("Failed to register through auth server: %v; falling back to trying the proxy server", err)
type registerMethod struct {
call func(token string, params RegisterParams) (*Identity, error)
desc string
}
registerThroughAuth := registerMethod{registerThroughAuth, "with auth server"}
registerThroughProxy := registerMethod{registerThroughProxy, "via proxy server"}

registerMethods := []registerMethod{registerThroughAuth, registerThroughProxy}
if params.GetHostCredentials == nil {
log.Debugf("Missing client, it is not possible to register through proxy.")
registerMethods = []registerMethod{registerThroughAuth}
} else if authServerIsProxy(params.Servers) {
log.Debugf("The first specified auth server appears to be a proxy.")
registerMethods = []registerMethod{registerThroughProxy, registerThroughAuth}
}

// params.AuthServers could contain a proxy address, to deal with nodes
// behind NAT. Try registering using the proxy API.
ident, err = registerThroughProxy(token, params)
var collectedErrs []error
for _, method := range registerMethods {
log.Infof("Attempting registration %s.", method.desc)
ident, err := method.call(token, params)
if err != nil {
return nil, trace.Wrap(err, "failed to register through proxy server: %v", err)
collectedErrs = append(collectedErrs, err)
log.WithError(err).Debugf("Registration %s failed.", method.desc)
continue
}

log.Debugf("Successfully registered through proxy server.")
log.Infof("Successfully registered %s.", method.desc)
return ident, nil
}
return nil, trace.NewAggregate(collectedErrs...)
}

log.Debugf("Successfully registered through auth server.")
return ident, nil
// authServerIsProxy returns true if the first specified auth server
// to register with appears to be a proxy.
func authServerIsProxy(servers []utils.NetAddr) bool {
return len(servers) > 0 && servers[0].Port(0) == defaults.HTTPListenPort
}

// registerThroughProxy is used to register through the proxy server.
func registerThroughProxy(token string, params RegisterParams) (*Identity, error) {
log.Debugf("Attempting to register through proxy server.")

if len(params.Servers) == 0 {
return nil, trace.BadParameter("no auth servers set")
}
Expand Down Expand Up @@ -167,8 +177,6 @@ func registerThroughProxy(token string, params RegisterParams) (*Identity, error

// registerThroughAuth is used to register through the auth server.
func registerThroughAuth(token string, params RegisterParams) (*Identity, error) {
log.Debugf("Attempting to register through auth server.")

var client *Client
var err error

Expand Down