Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid CORS Allow Origin Can Be Imported To Create New API #9212

Closed
exalate-issue-sync bot opened this issue Aug 29, 2023 · 1 comment
Closed

Invalid CORS Allow Origin Can Be Imported To Create New API #9212

exalate-issue-sync bot opened this issue Aug 29, 2023 · 1 comment
Labels
project: APIM type: bug

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Aug 29, 2023 •
edited
Loading

Describe the bug :

When an API definition has an invalid CORS allow origin (eg. $some_env_var), it can be imported and successfully create a new API.

To Reproduce :

Steps to reproduce the behaviour:

  1. Create a new API definition and set the CORS allow origin to a value that would not be considered valid (eg. $some_env_var)
  2. Go to create a new API and try to import it. This should be successful and result in a new API being created.
  3. For the now newly created API, try to import the same definition to update the API. This results in an error that points to the invalid CORS allow origin as the issue.

Expected behaviour :

If an invalid CORS allow origin is present in the API definition, it shouldn't be able to be successfully imported either to create a new API or update an existing one.

Current behaviour :

An API with an invalid CORS allow origin can be imported to create a new API but cannot be imported to update an existing API.

Useful information :

Screenshot, video, logs, other supporting material

Desktop :

  • Environment: 4.0.0, 3.20.14
  • Browser Chrome

* Please see Zendesk Support tab for further comments and attachments.
gaetanmaisse added a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 17, 2023
@gaetanmaisse
fix: check CORS Allow-origin format when importing an API
1e027be 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
@gaetanmaisse gaetanmaisse mentioned this issue Oct 17, 2023
Merged
gaetanmaisse added a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 17, 2023
@gaetanmaisse
fix: check CORS Allow-origin format when importing an API
be19b55 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
gaetanmaisse added a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse
fix: check CORS Allow-origin format when importing an API
701891e 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
gaetanmaisse added a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse
fix: check CORS Allow-origin format when importing an API
653c6bb 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
mergify bot pushed a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse @mergify
fix: check CORS Allow-origin format when importing an API
46c5650 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
(cherry picked from commit 653c6bb)

# Conflicts:
#	gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/ApiService_CreateWithDefinitionTest.java
@mergify mergify bot mentioned this issue Oct 18, 2023
Merged
mergify bot pushed a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse @mergify
fix: check CORS Allow-origin format when importing an API
1d5f05a 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
(cherry picked from commit 653c6bb)

# Conflicts:
#	gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/ApiService_CreateWithDefinitionTest.java
@mergify mergify bot mentioned this issue Oct 18, 2023
Merged
mergify bot pushed a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse @mergify
fix: check CORS Allow-origin format when importing an API
835bedf 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
(cherry picked from commit 653c6bb)

# Conflicts:
#	gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/ApiService_CreateWithDefinitionTest.java
@mergify mergify bot mentioned this issue Oct 18, 2023
Merged
gaetanmaisse added a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse
fix: check CORS Allow-origin format when importing an API
96f93c5 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
(cherry picked from commit 653c6bb)

# Conflicts:
#	gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/ApiService_CreateWithDefinitionTest.java
gaetanmaisse added a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse
fix: check CORS Allow-origin format when importing an API
b59b69d 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
(cherry picked from commit 653c6bb)

# Conflicts:
#	gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/ApiService_CreateWithDefinitionTest.java
gaetanmaisse added a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse
fix: check CORS Allow-origin format when importing an API
7b15bdf 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
(cherry picked from commit 653c6bb)

# Conflicts:
#	gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/ApiService_CreateWithDefinitionTest.java
gaetanmaisse added a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse
fix: check CORS Allow-origin format when importing an API
09b3e8a 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
(cherry picked from commit 653c6bb)

# Conflicts:
#	gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/ApiService_CreateWithDefinitionTest.java
gaetanmaisse added a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse
fix: check CORS Allow-origin format when importing an API
7fa8be3 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
(cherry picked from commit 653c6bb)

# Conflicts:
#	gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/ApiService_CreateWithDefinitionTest.java
gaetanmaisse added a commit to gravitee-io/gravitee-api-management that referenced this issue Oct 18, 2023
@gaetanmaisse
fix: check CORS Allow-origin format when importing an API
05f34ad 
https://gravitee.atlassian.net/browse/APIM-2604
gravitee-io/issues#9212
(cherry picked from commit 653c6bb)

# Conflicts:
#	gravitee-apim-rest-api/gravitee-apim-rest-api-service/src/test/java/io/gravitee/rest/api/service/impl/ApiService_CreateWithDefinitionTest.java
@exalate-issue-sync
Copy link
Author

This issue has been fixed in versions 4.0.11, 3.20.22, 4.2.0, 4.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project: APIM type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants