Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add description field to icons block #696

Merged
merged 3 commits into from
Nov 15, 2023
Merged

feat: add description field to icons block #696

merged 3 commits into from
Nov 15, 2023

Conversation

VitaliiDC8
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@yuberdysheva
Copy link
Contributor

Can you add please:

  1. transform support of title and description. Example:

    page-constructor/src/text-transform/config.ts

    Line 363 in 38d5b88

    [BlockType.CardLayoutBlock]: blockHeaderTransformer,
  2. File Icon.mdx with properties of block. (not necessary but would be great!)
    Thank you.

@VitaliiDC8 VitaliiDC8 merged commit e5f1a7d into main Nov 15, 2023
3 checks passed
@VitaliiDC8 VitaliiDC8 deleted the feat/add-description-to-icons branch November 15, 2023 11:51
@gravity-ui-bot gravity-ui-bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuberdysheva yuberdysheva yuberdysheva approved these changes

@gorgeousvlad gorgeousvlad Awaiting requested review from gorgeousvlad gorgeousvlad is a code owner

@NikitaCG NikitaCG Awaiting requested review from NikitaCG NikitaCG is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VitaliiDC8 @gravity-ui-bot @yuberdysheva