uikit5 #28
Merged
uikit5 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma-efremoff
force-pushed
the
uikit5
branch
3 times, most recently
from
6e4ef0c
to
d199b8c
Compare
amje
reviewed
Mar 1, 2024
package.json
Outdated
Comment on lines
95
to
96
| "@bem-react/classname": ">=1.6.0", | ||
| "prop-types": ">=15.8.0", |
There was a problem hiding this comment.
Why forcing to install these deps? Maybe move them to dependencies?
+ move "@bem-react/classname" to dependencies
amje
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.