Skip to content

Conversation

spivurno
Copy link
Contributor

HS#25575

This PR adds support for bypassing GP Limit Submissions feeds when editing an entry. It does some significant refactoring so we'll want to retest these three scenarios.

  1. Default functionality — updating an entry.
  2. Deleting a partial entry when Partial Entries is active and delete_partial parameter is true.
  3. Limit Submission feeds are bypassed when editing an entry.

@spivurno spivurno requested review from levisimon and eihabi June 30, 2021 01:38
@spivurno
Copy link
Contributor Author

@dariospace Assigning you as a reviewer for functionality. Could you step through the three scenarios above and make sure they work as expected?

@eihabi Assigning you for a code review. 🧐

@levisimon
Copy link
Contributor

@spivurno it seems that when the snippet is activated even with no configuration for form id, it bypasses the Limit Submissions Feeds and allows creating new entries. I did a short video: loom

…pdate entry was found instead of only configured form.
@spivurno
Copy link
Contributor Author

@dariospace Fixed. Could you try again? 🙏

spivurno added 2 commits June 30, 2021 13:11
…et form that it also has an active feed. Now we loop through to find an active feed before returning an update entry ID.
@eihabi
Copy link
Contributor

eihabi commented Jul 1, 2021

@spivurno I'm waiting for the dust to settle and @dariospace's review before digging in 👍

spivurno added 3 commits July 4, 2021 11:56
~ Updated snippet to prevent updating when EP has not populated values into the form.
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@spivurno spivurno merged commit ed213ef into master Jul 14, 2021
@spivurno spivurno deleted the dave/add/gpls-support branch July 14, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants