gpnf-override-parent-merge-tag-on-submission: Updated to a class and made configuration for multiple child forms easier.
#533
+127
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veryspry
requested review from
claygriffiths,
spivurno and
saifsultanc
and removed request for
spivurno
veryspry
commented
Sep 28, 2022
gp-nested-forms/gpnf-override-parent-merge-tag-on-submission.php
Outdated
Show resolved
Hide resolved
|
I added an additional config option called @spivurno Let me know what you think of this API change! |
|
@veryspry Love it! |
claygriffiths
approved these changes
Sep 30, 2022
gp-nested-forms/gpnf-override-parent-merge-tag-on-submission.php
Outdated
Show resolved
Hide resolved
gp-nested-forms/gpnf-override-parent-merge-tag-on-submission.php
Outdated
Show resolved
Hide resolved
veryspry
changed the title
gpnf-override-parent-merge-tag-on-submission.php into a classgpnf-override-parent-merge-tag-on-submission.php: refactor into a class and add make configuration for multiple child forms easier.
veryspry
changed the title
gpnf-override-parent-merge-tag-on-submission.php: refactor into a class and add make configuration for multiple child forms easier.gpnf-override-parent-merge-tag-on-submission: refactor into a class and add make configuration for multiple child forms easier.
veryspry
force-pushed
the
matt/refactor-parent-merge-tag-override
branch
from
9b120e9 to
e55ab63
Compare
veryspry
changed the title
gpnf-override-parent-merge-tag-on-submission: refactor into a class and add make configuration for multiple child forms easier.gpnf-override-parent-merge-tag-on-submission: Refactor into a class and add make configuration for multiple child forms easier.
|
We are currently waiting for a user to confirm that it works for them. After that, I'll merge! |
veryspry
changed the title
gpnf-override-parent-merge-tag-on-submission: Refactor into a class and add make configuration for multiple child forms easier.gpnf-override-parent-merge-tag-on-submission into a class and make configuration for multiple child forms easier.
veryspry
force-pushed
the
matt/refactor-parent-merge-tag-override
branch
from
e55ab63 to
d3c8df7
Compare
veryspry
changed the title
gpnf-override-parent-merge-tag-on-submission into a class and make configuration for multiple child forms easier.gpnf-override-parent-merge-tag-on-submission: Refactor into a class and make configuration for multiple child forms easier.
veryspry
force-pushed
the
matt/refactor-parent-merge-tag-override
branch
2 times, most recently
from
8e24810 to
67fc5a6
Compare
veryspry
changed the title
gpnf-override-parent-merge-tag-on-submission: Refactor into a class and make configuration for multiple child forms easier.gpnf-override-parent-merge-tag-on-submission: Refactored into a class and made configuration for multiple child forms easier.
…ss and made configuration for multiple child forms easier.
veryspry
force-pushed
the
matt/refactor-parent-merge-tag-override
branch
from
67fc5a6 to
e6fe114
Compare
veryspry
changed the title
gpnf-override-parent-merge-tag-on-submission: Refactored into a class and made configuration for multiple child forms easier.gpnf-override-parent-merge-tag-on-submission: Updated to a class and made configuration for multiple child forms easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2015154047/38861/
It is difficult to configure
gpnf-override-parent-merge-tag-on-submission.phpfor multiple child forms. This enables users to more easily apply the logic to multiple child forms.Summary
GPNF_Override_Parent_Merge_Tagsper child form a user wants to configure.GPNF_Override_Parent_Merge_Tagswith no arguments to apply this to all child forms.