Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2gs parsing trouble with unknown data structures 22, 24, 26, 28 #66

Closed
dsjoerg opened this issue Jul 24, 2012 · 5 comments
Closed

s2gs parsing trouble with unknown data structures 22, 24, 26, 28 #66

dsjoerg opened this issue Jul 24, 2012 · 5 comments
Assignees

Comments

@dsjoerg
Copy link
Collaborator

dsjoerg commented Jul 24, 2012

the s2gs hashes are private, will send them in separate message.

@ghost ghost assigned GraylinKim Jul 24, 2012
@GraylinKim
Copy link
Owner

All these s2gs parsing problems should be fixed at this point. Reopen if you disagree.

@dsjoerg
Copy link
Collaborator Author

dsjoerg commented Oct 10, 2012

That word "should" scares me. Did you try parsing the s2gs files corresponding to the hashes I sent when this issue was opened?

@dsjoerg dsjoerg reopened this Oct 10, 2012
@GraylinKim
Copy link
Owner

Sorry, I should be more affirmative with my language!

Anyway, I went back over all the s2gs files on my possession and confirmed the fix. I also found and fixed a couple weird issues with settings in s2gs files for custom maps in 32297ce and 92ed828. I also confirmed that all your integration tests passed before and after the changes. s2gs should be good to go!

@dsjoerg
Copy link
Collaborator Author

dsjoerg commented Oct 13, 2012

BOOM

@dsjoerg
Copy link
Collaborator Author

dsjoerg commented Oct 13, 2012

Ha, you managed to sneak a "should" in the beginning and the end of your "affirmative" language. You should be ashamed!

StoicLoofah referenced this issue in StoicLoofah/sc2reader Nov 1, 2018
CircleCI: Upgrade from Python 3.6 —> 3.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants