Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL warning in http notification form does not update after allowing URL. #19013

Open
linuspahl opened this issue Apr 11, 2024 · 6 comments
Open

Comments

@linuspahl
Copy link
Contributor

linuspahl commented Apr 11, 2024

Description

When you create an http notification and you add an URL, which is not allowed yet, you will see the following warning:

image

Once you allow the URL in the related modal, the warning stays there (and the form submit button stays disabled) and only disappears after allowing the URL again.

This issue does not seem to occur in the current master version.

Your Environment

  • Graylog Version: 6.0 rc2
@kmerz kmerz added blocker If not finished by release date, the release will be postponed. triaged labels Apr 12, 2024
@kmerz
Copy link
Member

kmerz commented Apr 12, 2024

Probably needs only a backport!

@kmerz kmerz removed blocker If not finished by release date, the release will be postponed. triaged labels Apr 12, 2024
@kmerz
Copy link
Member

kmerz commented Apr 12, 2024

Not a blocker, since there is a workaround.

@grotlue
Copy link
Contributor

grotlue commented May 7, 2024

I couldn't reproduce this either in 6.0.1 or in 6.0.rc.

@grotlue
Copy link
Contributor

grotlue commented May 7, 2024

On test-dev-ng with 6.0.1 cloud I can reproduce it. Locally with 6.0.1 cloud not.

@grotlue
Copy link
Contributor

grotlue commented May 7, 2024

On test-dev-ng where I can reproduce it, the call is sending the new whitelist correctly, but the check call returns the url as not whitelisted.
Screenshot 2024-05-07 at 18 01 22
Screenshot 2024-05-07 at 18 01 28

@patrickmann patrickmann self-assigned this May 8, 2024
@patrickmann
Copy link
Contributor

patrickmann commented May 8, 2024

I also could only reproduce it on test-dev-ng.
The backend code for URL white-listing has not changed since 5.2. and API responses look fine.
Custom HTTP Notification was recently added and is therefore suspect. But the problem also reproduces in the legacy HTTP Notification, which has not changed as recently.
Running out of ideas. Maybe we can table this until we see a repro outside of test-dev-ng?

@patrickmann patrickmann removed their assignment May 8, 2024
@grotlue grotlue removed their assignment Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants