Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useSigningClient is created using the wrong offlineSigner, meaning ledger's do not work #21

Closed
Callum-A opened this issue Jul 27, 2022 · 1 comment
Closed

useSigningClient is created using the wrong offlineSigner, meaning ledger's do not work #21

Callum-A opened this issue Jul 27, 2022 · 1 comment
Assignees
@grikomsn @codingki
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Callum-A
Copy link
Contributor

It currently uses the signer from keplr.getOfflineSigner(chainId) when it should use keplr.getOfflineSignerAuto(chainId), maybe this should be specified by a flag as I am unsure if it breaks other bindings?
@grikomsn grikomsn self-assigned this Jul 27, 2022
@grikomsn grikomsn added bug Something isn't working help wanted Extra attention is needed labels Jul 27, 2022
codingki added a commit that referenced this issue Aug 9, 2022
@codingki
fix(signingClients): change offlineSigner to offlineSignerAuto #21
e7857d0
@codingki
Copy link
Member

codingki commented Aug 9, 2022 •
edited
Loading

@Callum-A fixed on v0.0.12 Thanks for the report

@codingki codingki closed this as completed Aug 9, 2022
@codingki codingki mentioned this issue Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grikomsn grikomsn

@codingki codingki

Labels
bug Something isn't working help wanted Extra attention is needed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grikomsn @codingki @Callum-A