Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker image for docker-hub #49

Merged
merged 10 commits into from
Jul 20, 2018
Merged

docker image for docker-hub #49

merged 10 commits into from
Jul 20, 2018

Conversation

h-bragg
Copy link
Contributor

@h-bragg h-bragg commented Jul 12, 2018

This is to create a docker image on dockerhub to be able to run morphism.

  • Updates code to conform to phpcs
  • Updates some dev depenencies
  • Makefile conforms to current standards
  • .travis.yml conforms to current standards

docker image for docker-hub
85baf78 
- Updates code to conform to phpcs
- Updates some dev depenencies
- Makefile conforms to current standards
- .travis.yml conforms to current standards
@h-bragg h-bragg requested a review from biggianteye July 13, 2018 08:37
@biggianteye
Copy link
Contributor

The coverage command no longer works. It works in master:

[burhan@enceladus morphism (morphism-docker-image)] {0} $ make test-coverage
/usr/local/bin/docker run --rm -t -v $(pwd):/srv -w /srv graze/php-alpine:7.2-test phpdbg7 -qrr vendor/bin/phpunit --coverage-text
PHPUnit 7.2.6 by Sebastian Bergmann and contributors.

Error:         Incorrect whitelist config, no code coverage will be generated.

...............................................................  63 / 696 (  9%)
............................................................... 126 / 696 ( 18%)
............................................................... 189 / 696 ( 27%)
............................................................... 252 / 696 ( 36%)
............................................................... 315 / 696 ( 45%)
............................................................... 378 / 696 ( 54%)
............................................................... 441 / 696 ( 63%)
............................................................... 504 / 696 ( 72%)
............................................................... 567 / 696 ( 81%)
............................................................... 630 / 696 ( 90%)
............................................................... 693 / 696 ( 99%)
...                                                             696 / 696 (100%)

Time: 838 ms, Memory: 8.00MB

OK (696 tests, 836 assertions)

@h-bragg
Copy link
Contributor Author

h-bragg commented Jul 13, 2018

added whitelist for coverage

biggianteye
biggianteye approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@biggianteye biggianteye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Awesome work!

README.md Outdated
With Docker

```bash
$ docker run --rm graze/morphism
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Morphism needs access to a conf file so consider adding some volume mounting to this example.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tangent: I'll add a issue to have a default conf file name.

@biggianteye biggianteye mentioned this pull request Jul 13, 2018
Open
@biggianteye
Copy link
Contributor

Upgrading the phpunit coverage library (2.2.4 -> 6.0.7 !!!) has made #14 more apparent. Good in the long run.

@h-bragg h-bragg merged commit 8ea2289 into master Jul 20, 2018
@h-bragg h-bragg deleted the morphism-docker-image branch July 20, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biggianteye biggianteye biggianteye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-bragg @biggianteye