Add the mockery test listener to the phpunit config #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That makes sense. Looks sensible (with isValid) apart from lots of repeated code. At least its clear whats going on. 👍 |
|
Thanks! |
sjparkinson
added a commit
that referenced
this pull request
Jun 24, 2015
Add the mockery test listener to the phpunit config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having some issues with Mockery expectation validation in #9, turns out it was because we were not calling
Mockery::close().This PR adds the bundled mockery test listener to the phpunit config.
See http://docs.mockery.io/en/latest/reference/phpunit_integration.html.
There were three errors that resulted in adding the listener, which these changes "resolve".
I couldn't work out if Jake intended there to be three calls to
isValidin all the handlers, hence the PR to get a sanity check 😕.