Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportError: cannot import name '_RelativePathExtension' from 'mkdocs.structure.pages' #1100

Closed
Lucas-C opened this issue Aug 1, 2023 · 6 comments

Comments

@Lucas-C
Copy link

Lucas-C commented Aug 1, 2023

Hi,

This import is now invalid:
https://github.com/greenape/mknotebooks/blob/master/mknotebooks/plugin.py#L17

This changed in PR mkdocs/mkdocs#3283 that was released in mkdocs 1.5.0 last week.

I have just discovered that in this GitHub Actions pipeline exection:
https://github.com/PyFPDF/fpdf2/actions/runs/5731678301/job/15533085644

@CribberSix
Copy link

Same here. Removed the plugin from our repositories for the time being.

@Lucas-C
Copy link
Author

Lucas-C commented Aug 4, 2023

Yes, I also had to disable mknotebooks for now: https://github.com/PyFPDF/fpdf2/blob/master/mkdocs.yml#L54

@SoumayaMauthoorMOJ
Copy link

greenape added a commit that referenced this issue Aug 7, 2023
@greenape
Copy link
Owner

greenape commented Aug 8, 2023

This should now be fixed.

@greenape greenape closed this as completed Aug 8, 2023
@CribberSix
Copy link

This is great news! Thank you so much!

@Lucas-C
Copy link
Author

Lucas-C commented Aug 13, 2023

Thank you @greenape, I confirm that this is now fixed for my use-case 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants