Use poetry for dependency management #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poetry will replace pipenv in the autohooks project.
Allow to get the poetry settings easily by using a config class.
Use the version from pyproject.toml and poetry config.
We don't support python 2 and running setup.py with python 2 will fail with an import error for `from pathlib import Path`
Use the poetry config from the pyproject.toml file to set most setting in setup.py. We are still using setup.py instead of poetry as a build-system (PEP 517) because setup.py allows us to activate the git hooks as a post install when beeing installed via a source distribution (.tar.gz file).
Drop pipenv usage from RELEASE.md.
Drop support for pipenv
Poetry seems to be very good at finding all packages even namespace packages.
Using the pyproject.toml file for loading the version number doesn't work because at runtime after installation the pyproject.toml file is not part of the python package and therefore not available at all.
Update circleci config to use poetry instead of pipenv now.
Always create a new pypirc when running the deploy target of circleci.
tomlkit will allow to preserve the style and layout of the toml files.
Use the new internal safe_version function instead.
This is a slightly modified version from python-gvm.
When changing the version and uploading a new tag the version information will be checked.
setuptools are required for installing autohooks at the moment.
This is a leftover from exchanging toml with tomlkit.
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 43.95% 51.63% +7.68%
==========================================
Files 13 14 +1
Lines 571 732 +161
==========================================
+ Hits 251 378 +127
- Misses 320 354 +34
Continue to review full report at Codecov.
|
When creating the environment poetry internally uses venv. It seems venv always installs the pip and setuptools version provided with the python version. In case of python 3.5. these versions are to old for autohooks.
We replaced pipenv with poetry.
wiegandm
suggested changes
Apr 7, 2020
Co-Authored-By: Michael Wiegand <wiegandm@users.noreply.github.com>
wiegandm
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: