Add: Certificate info for TippingPoint alerts #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #3708 +/- ##
==========================================
- Coverage 60.12% 60.10% -0.02%
==========================================
Files 1020 1021 +1
Lines 25123 25132 +9
Branches 7418 7423 +5
==========================================
+ Hits 15104 15105 +1
- Misses 9079 9087 +8
Partials 940 940
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The alert dialog now uses the correct field for TLS workaround option of the TippingPoint SMS method. Previously the wrong field was used, so the dialog did not work correctly.
The details of alerts using the TippingPoint SMS method now shows information about the TLS certificate. This way it is possible to check if the correct certificate is configured or not.
timopollmeier
force-pushed
the
add-tp-sms-certificate-info
branch
from
98f20b9
to
fada909
Compare
jhelmold
approved these changes
May 22, 2023
jhelmold
added a commit
that referenced
this pull request
Jun 9, 2023
Add: Certificate info for TippingPoint alerts (backport #3708)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The details of alerts using the TippingPoint SMS method now shows
information about the TLS certificate.
Why
This way it is possible to check if the correct certificate is
configured or not.
References
GEA-180
requires greenbone/gvmd/pull/1972