Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user setting time date format #4144

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

daniele-mng
Copy link
Contributor

What

  • Introduced user setting for custom and default system date and time.

Why

  • These changes are necessary to provide users with customizable and localized options for displaying date and time.

References

GEA-430

Checklist

  • Tests

@daniele-mng daniele-mng requested a review from a team as a code owner September 2, 2024 07:56
Copy link

github-actions bot commented Sep 2, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA c7b3f4b.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Sep 2, 2024

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

@daniele-mng daniele-mng force-pushed the Add-user-setting-time-date-format branch 2 times, most recently from 8705821 to b4b7c05 Compare September 2, 2024 09:09
Copy link
Contributor

@a-h-abdelsalam a-h-abdelsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only added a few comments.
I cannot judge the German translations so maybe someone else can take a look on that.

src/web/pages/overrides/detailspage.jsx Outdated Show resolved Hide resolved
src/gmp/commands/users.js Outdated Show resolved Hide resolved
src/web/pages/usersettings/usersettingspage.jsx Outdated Show resolved Hide resolved
Copy link

@4D617274696E 4D617274696E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed German translations, looks good.

@daniele-mng daniele-mng force-pushed the Add-user-setting-time-date-format branch from 570e39b to e070a3e Compare September 6, 2024 12:33
@daniele-mng daniele-mng force-pushed the Add-user-setting-time-date-format branch from e070a3e to c7b3f4b Compare October 16, 2024 08:19
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 53.98230% with 208 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (ed32a25) to head (c7b3f4b).
Report is 11 commits behind head on opensight-ui.

Files with missing lines Patch % Lines
src/web/pages/usersettings/usersettingspage.jsx 0.00% 72 Missing ⚠️
src/web/pages/usersettings/generalpart.jsx 0.00% 69 Missing ⚠️
src/web/pages/usersettings/dialog.jsx 0.00% 19 Missing ⚠️
src/web/pages/login/loginpage.jsx 71.87% 9 Missing ⚠️
src/web/utils/userSettingTimeDateFormatters.js 77.50% 9 Missing ⚠️
src/web/components/chart/schedule.jsx 16.66% 5 Missing ⚠️
src/web/pages/notes/detailspage.jsx 20.00% 4 Missing ⚠️
src/web/pages/overrides/detailspage.jsx 20.00% 4 Missing ⚠️
src/gmp/commands/users.js 62.50% 3 Missing ⚠️
src/web/pages/tasks/icons/scheduleicon.jsx 25.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files
@@               Coverage Diff                @@
##           opensight-ui    #4144      +/-   ##
================================================
- Coverage         64.39%   64.31%   -0.08%     
================================================
  Files              1111     1111              
  Lines            103662   103884     +222     
  Branches           6466     6479      +13     
================================================
+ Hits              66755    66816      +61     
- Misses            36767    36929     +162     
+ Partials            140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-h-abdelsalam a-h-abdelsalam merged commit f49afb2 into opensight-ui Oct 16, 2024
8 of 10 checks passed
@a-h-abdelsalam a-h-abdelsalam deleted the Add-user-setting-time-date-format branch October 16, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants