Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed send-targets.gmp.py script because alive_test needs to be enum in create_target. #297

Merged
merged 6 commits into from
Sep 26, 2020

Conversation

omok314159
Copy link

What:

Fixed send-targets.gmp.py script because alive_test needs to be enum in create_target.
Why:
Now alive_test needs to be enum in create_target function. And send-targets.gmp.py was not support it.
When XML is <alive_tests>Conside Alive</alive_tests> or this kind of thing, the script could not handle it.

How:
I exported several XML from target with several "alive_test", and use it as template to create target by using fixed send-targets.gmp.py. It worked fine.

Checklist:

@omok314159 omok314159 requested a review from a team as a code owner September 25, 2020 03:10
CHANGELOG.md Outdated Show resolved Hide resolved
scripts/send-targets.gmp.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@omok314159
Copy link
Author

Thanks. I didn't know that function. I change my own function to get_alive_test_from_string.

@omok314159
Copy link
Author

Sorry, I had some conflict in my local repo. I fixed it, so send-targets.gmp.py script is now updated.

@y0urself
Copy link
Member

Thank you!

@y0urself y0urself merged commit 4c2567c into greenbone:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants