Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving monthly report and combine report scripts #370

Merged
merged 32 commits into from
Jan 21, 2021
Merged

Improving monthly report and combine report scripts #370

merged 32 commits into from
Jan 21, 2021

Conversation

y0urself
Copy link
Member

@y0urself y0urself commented Jan 18, 2021 •
edited
Loading

What:

  • Refactoring combine-report, monthly-report
  • Introducing new create-monthly-report script

Why:

How:

Checklist:

@y0urself y0urself changed the title Improving monthly scripts Improving monthly report and combine report scripts Jan 18, 2021
@y0urself y0urself marked this pull request as ready for review January 19, 2021 17:49
@y0urself y0urself requested a review from a team as a code owner January 19, 2021 17:49
bjoernricks
bjoernricks suggested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just please add more type hints for the new script.

scripts/create-consolidated-report.gmp.py Outdated Show resolved Hide resolved
scripts/create-consolidated-report.gmp.py Outdated Show resolved Hide resolved
scripts/create-consolidated-report.gmp.py Outdated Show resolved Hide resolved
scripts/create-consolidated-report.gmp.py Outdated Show resolved Hide resolved
scripts/create-consolidated-report.gmp.py Outdated Show resolved Hide resolved
scripts/create-consolidated-report.gmp.py Outdated Show resolved Hide resolved
scripts/create-consolidated-report.gmp.py Outdated Show resolved Hide resolved
bjoernricks
bjoernricks suggested changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@bjoernricks bjoernricks self-requested a review January 21, 2021 07:04
bjoernricks
bjoernricks approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry did click on the wrong radio button ;-)

@bjoernricks bjoernricks merged commit 85289d7 into greenbone:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y0urself @bjoernricks