Change: improve handling of sensitive data #1461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Change: improve handling of sensitive data
Jira: SC-877
Why:
With this patch, sentitive data, like credential, are hidden when GET scan_id, and delete from the scan config once the scan was started.
How:
Run a scan with, the scan must contain credentials, of course:
curl --verbose --insecure --cert $CLIENT_CERT --cert-type PEM --key $CLIENT_KEY --request POST https://127.0.0.1:3000/scans -H "X-API-KEY: changeme" -d '@/tmp/simple_scan.json' | jq
And get the scan before and after staring it. Credentials shouldn't be shown after the path is applied.
curl --verbose --insecure --cert $CLIENT_CERT --cert-type PEM --key $CLIENT_KEY --request GET https://127.0.0.1:3000/scans/<THE SCAN ID> -H "X-API-KEY: changeme" | jq .
Checklist: