[1.0] Improve error handling when creating vts xml elements. #139
Conversation
Avoid ospd to crash if there is an invalid char.
Codecov Report
@@ Coverage Diff @@
## ospd-openvas-1.0 #139 +/- ##
===================================================
+ Coverage 69.83% 71.54% +1.7%
===================================================
Files 4 4
Lines 935 963 +28
===================================================
+ Hits 653 689 +36
+ Misses 282 274 -8
Continue to review full report at Codecov.
|
| @@ -1017,11 +1082,9 @@ def stop_scan_cleanup( | |||
| self.openvas_db.release_db(current_kbi) | |||
| for host_kb in range(0, self.openvas_db.max_dbindex): | |||
| self.openvas_db.select_kb( | |||
| ctx, | |||
There was a problem hiding this comment.
These formatting changes would have been better in a separate commit.
There was a problem hiding this comment.
I did not realize about this since it is done automatically when I commit. There is a hook which runs black.
| @@ -626,7 +626,7 @@ def get_dependencies_vt_as_xml_str( | |||
| _vt_dep = Element('dependency') | |||
| try: | |||
| _vt_dep.set('vt_id', dep) | |||
| except TypeError: | |||
There was a problem hiding this comment.
This doesn't seem to be about improving the tests.
There was a problem hiding this comment.
You are right. This improves the error handling, not the test. But it is related to the first commit. I should have done this with the first commit or in a separated one.
jjnicola
force-pushed
the
try-xml-text-1
branch
from
d27ebea
to
41019ed
Compare
Refactor stream handling
Avoid ospd to crash if there is an invalid char.