Add set_nvticache_str(). #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
force-pushed
the
nvticache
branch
2 times, most recently
from
2c5b2e7
to
81960ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #150 +/- ##
==========================================
+ Coverage 71.25% 71.59% +0.34%
==========================================
Files 4 4
Lines 981 1000 +19
==========================================
+ Hits 699 716 +17
- Misses 282 284 +2
Continue to review full report at Codecov.
|
jjnicola
force-pushed
the
nvticache
branch
2 times, most recently
from
771fa61
to
e61936a
Compare
The nvticache name in redis (dependent on the gvm-libs) will be checked for compatibility against a list of supported nvticache versions.
bjoernricks
requested changes
Nov 14, 2019
There was a problem hiding this comment.
Personally I am not sure about using distutils in python 3 because it is more or less deprecated. Instead I would use pkg_resource parse_version which comes with setuptools. The reason behind this is pkg_resources parse_version is PEP 440 compatible and i don't know if this is true for distutils.
jjnicola
added
the
Work in progress
jjnicola
removed
the
Work in progress
bjoernricks
reviewed
Nov 15, 2019
bjoernricks
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nvticache name in redis (dependent on the gvm-libs) will be checked
for compatibility against a list of supported nvticache versions.