-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start server before initialize the vts. #196
Conversation
ae3cd4d
to
71b60b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 75.06% 74.97% -0.09%
==========================================
Files 5 5
Lines 1175 1179 +4
==========================================
+ Hits 882 884 +2
- Misses 293 295 +2
Continue to review full report at Codecov.
|
71b60b1
to
8bf0f3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me already! Is this PR for fixing the nasty could not connect to the scanner warnings in gvmd?
Yes. Now the socket is created during the init and it is able to respond to client with an error until it finishes the initialization. |
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 75.06% 74.97% -0.09%
==========================================
Files 5 5
Lines 1175 1179 +4
==========================================
+ Hits 882 884 +2
- Misses 293 295 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. I think it would even be possible to return responses for some commands if the daemon isn't initialized yet. E.g. get_help or get_memory_usage don't require the vts to be loaded already.
Update pylintrc
Depends on PR greenbone/ospd#209