Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start server before initialize the vts. #196

Merged
merged 3 commits into from
Feb 20, 2020

Conversation

jjnicola
Copy link
Member

Depends on PR greenbone/ospd#209

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #196 into master will decrease coverage by 0.08%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   75.06%   74.97%   -0.09%     
==========================================
  Files           5        5              
  Lines        1175     1179       +4     
==========================================
+ Hits          882      884       +2     
- Misses        293      295       +2
Impacted Files Coverage Δ
ospd_openvas/daemon.py 62.33% <60%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7bfb8...6f9e314. Read the comment docs.

Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me already! Is this PR for fixing the nasty could not connect to the scanner warnings in gvmd?

@jjnicola
Copy link
Member Author

Looks good to me already! Is this PR for fixing the nasty could not connect to the scanner warnings in gvmd?

Yes. Now the socket is created during the init and it is able to respond to client with an error until it finishes the initialization.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #196 into master will decrease coverage by 0.08%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   75.06%   74.97%   -0.09%     
==========================================
  Files           5        5              
  Lines        1175     1179       +4     
==========================================
+ Hits          882      884       +2     
- Misses        293      295       +2
Impacted Files Coverage Δ
ospd_openvas/daemon.py 62.33% <60%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c7bfb8...6f9e314. Read the comment docs.

@jjnicola jjnicola marked this pull request as ready for review February 19, 2020 15:02
Copy link
Member

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw. I think it would even be possible to return responses for some commands if the daemon isn't initialized yet. E.g. get_help or get_memory_usage don't require the vts to be loaded already.

@jjnicola jjnicola merged commit e11401a into greenbone:master Feb 20, 2020
@jjnicola jjnicola deleted the start-server branch February 20, 2020 08:20
ArnoStiefvater pushed a commit to ArnoStiefvater/ospd-openvas that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants